x86: hvm_*io_intercept() should only update p->count if X86EMUL_OKAY.
authorKeir Fraser <keir.fraser@citrix.com>
Wed, 1 Apr 2009 15:20:30 +0000 (16:20 +0100)
committerKeir Fraser <keir.fraser@citrix.com>
Wed, 1 Apr 2009 15:20:30 +0000 (16:20 +0100)
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Signed-off-by: Keir Fraser <keir.fraser@citrix.com>
xen/arch/x86/hvm/intercept.c

index 107b87d2f700ecf2162f56a042c026aedacde6da..1a1f24c7f68ae110d05b8d334272c2ee6cfb95e1 100644 (file)
@@ -100,8 +100,11 @@ static int hvm_mmio_access(struct vcpu *v,
         }
     }
 
-    if ( (p->count = i) != 0 )
+    if ( i != 0 )
+    {
+        p->count = i;
         rc = X86EMUL_OKAY;
+    }
 
     return rc;
 }
@@ -165,8 +168,11 @@ static int process_portio_intercept(portio_action_t action, ioreq_t *p)
         }
     }
 
-    if ( (p->count = i) != 0 )
+    if ( i != 0 )
+    {
+        p->count = i;
         rc = X86EMUL_OKAY;
+    }
 
     return rc;
 }